Repository navigation
chore(ci): run integration on v1-base - #555
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 2280 2280
Branches 737 737
=========================================
Hits 2280 2280 🚀 New features to boost your workflow:
|
Contributor
|
Size Change: 0 B Total Size: 114 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Integration workflow only runs for pushes to
mainand pull requests targetingmain, so pull requests targetingv1-baseget no lint, type, test, coverage, or JSDoc checks.This adds
v1-baseto both thepushandpull_requestbranch filters ofintegration.yml, as suggested in #552 (comment).The other workflows are left as they are:
autofix.yml,compressed-size.yml,auto-assign-author.ymlhave no branch filter on pull requests, so they already run forv1-basepull requests.release.ymlmust stay onmainonly, otherwise changesets onv1-basewould be versioned and published.Notes:
v1-baseonce this change reaches that branch, somainwill be merged intov1-baseafter this is merged.v1-base,dorny/paths-filtercompares against the default branch, so the coverage and JSDoc jobs check every file changed onv1-baseso far rather than only the pushed commits.v1-baseis merged intomain.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?