Add no-op support for JVM / JS targets - #102
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new “Supported targets” doc text is misleading about Bugsnag JVM/JS support and should be clarified for accuracy.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds JVM and JS “no-op” support so CrashKiOS can be depended on from commonMain in multiplatform projects that also target JVM/JS, aligning with the linked feature request discussion.
Changes:
- Added JVM/JS actual implementations for Crashlytics/Bugsnag calls that intentionally no-op on unsupported targets.
- Added JVM/JS actual implementations for
ThreadSafeVarand enabledjvm+jstargets in affected modules. - Updated docs to describe supported targets and committed the Kotlin/JS yarn lockfile for the new JS targets.
File summaries
| File | Description |
|---|---|
| website/docs/index.md | Documents JVM/JS no-op behavior and guidance for using commonMain. |
| kotlin-js-store/yarn.lock | Adds Kotlin/JS-generated Yarn lockfile needed by the new JS targets. |
| crashlytics/src/jvmMain/.../CrashlyticsCallsActual.kt | JVM no-op Crashlytics actual implementation. |
| crashlytics/src/jsMain/.../CrashlyticsCallsActual.kt | JS no-op Crashlytics actual implementation. |
| crashlytics/build.gradle.kts | Enables JVM + JS targets for the crashlytics module. |
| core/src/jvmMain/.../ThreadSafeVar.kt | JVM actual implementation of ThreadSafeVar. |
| core/src/jsMain/.../ThreadSafeVar.kt | JS actual implementation of ThreadSafeVar. |
| core/build.gradle.kts | Enables JVM + JS targets for the core module. |
| bugsnag/src/jvmMain/.../BugsnagCallsActual.kt | JVM no-op Bugsnag actual implementation. |
| bugsnag/src/jsMain/.../BugsnagCallsActual.kt | JS no-op Bugsnag actual implementation. |
| bugsnag/build.gradle.kts | Enables JVM + JS targets for the bugsnag module. |
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wellingtoncosta
force-pushed
the
wp/no-op-support-jvm-jv-targets
branch
from
September 8, 2026 19:29
92e1471 to
c12235d
Compare
ignacio-touchlab
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion #101