Skip to content

Add no-op support for JVM / JS targets - #102

Merged
wellingtoncosta merged 1 commit into
mainfrom
wp/no-op-support-jvm-jv-targets
Sep 10, 2026
Merged

wellingtoncosta merged 1 commit into
mainfrom
wp/no-op-support-jvm-jv-targets

Conversation

@wellingtoncosta

Copy link
Copy Markdown
Contributor

See discussion #101

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new “Supported targets” doc text is misleading about Bugsnag JVM/JS support and should be clarified for accuracy.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds JVM and JS “no-op” support so CrashKiOS can be depended on from commonMain in multiplatform projects that also target JVM/JS, aligning with the linked feature request discussion.

Changes:

  • Added JVM/JS actual implementations for Crashlytics/Bugsnag calls that intentionally no-op on unsupported targets.
  • Added JVM/JS actual implementations for ThreadSafeVar and enabled jvm + js targets in affected modules.
  • Updated docs to describe supported targets and committed the Kotlin/JS yarn lockfile for the new JS targets.
File summaries
File Description
website/docs/index.md Documents JVM/JS no-op behavior and guidance for using commonMain.
kotlin-js-store/yarn.lock Adds Kotlin/JS-generated Yarn lockfile needed by the new JS targets.
crashlytics/src/jvmMain/.../CrashlyticsCallsActual.kt JVM no-op Crashlytics actual implementation.
crashlytics/src/jsMain/.../CrashlyticsCallsActual.kt JS no-op Crashlytics actual implementation.
crashlytics/build.gradle.kts Enables JVM + JS targets for the crashlytics module.
core/src/jvmMain/.../ThreadSafeVar.kt JVM actual implementation of ThreadSafeVar.
core/src/jsMain/.../ThreadSafeVar.kt JS actual implementation of ThreadSafeVar.
core/build.gradle.kts Enables JVM + JS targets for the core module.
bugsnag/src/jvmMain/.../BugsnagCallsActual.kt JVM no-op Bugsnag actual implementation.
bugsnag/src/jsMain/.../BugsnagCallsActual.kt JS no-op Bugsnag actual implementation.
bugsnag/build.gradle.kts Enables JVM + JS targets for the bugsnag module.
Review details
  • Files reviewed: 10/11 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread website/docs/index.md Outdated
@wellingtoncosta
wellingtoncosta merged commit dc92ee6 into main Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants