Stop publishing wheels older Python versions and specific architectures/platforms#306
Stop publishing wheels older Python versions and specific architectures/platforms#306jo-sm wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe ChangesBuild Matrix Narrowing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-binaries.yml:
- Line 70: There is a mismatch between the Python versions declared as supported
in pyproject.toml (requires-python = ">=3.10" with classifiers for 3.10, 3.11,
3.12, 3.13, 3.14) and the versions actually being built and tested in the CI
workflows. The build-binaries.yml python-version matrix only includes 3.12,
3.13, and 3.14 (at lines 70, 115, 168 and maturin invocations at lines 216, 265,
316, 355), and test-python.yml only uses 3.12. Either update pyproject.toml to
change requires-python to ">=3.12" and remove the 3.10/3.11 classifiers if
support for those versions is intentionally dropped, or add Python 3.10 and 3.11
to the python-version matrix in build-binaries.yml and test-python.yml workflows
and update the .python-version file to match the minimum supported version if
those versions should remain supported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 045e0899-0503-49c3-9560-6b54e0fb47e0
📒 Files selected for processing (1)
.github/workflows/build-binaries.yml
| # Python 3.9/3.10 macOS builds require libintl from Homebrew gettext, | ||
| # which is not available on macos-15 runners | ||
| python-version: ["3.11", "3.12", "3.13", "3.14"] | ||
| python-version: ["3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether Python 3.10/3.11 are still covered anywhere in CI and metadata.
set -euo pipefail
echo "== Declared Python support in pyproject =="
fd -a pyproject.toml | xargs -I{} sh -c 'echo "--- {} ---"; sed -n "1,140p" "{}" | rg -n "requires-python|Programming Language :: Python :: 3\.(10|11|12|13|14)"'
echo
echo "== Workflow coverage for 3.10/3.11 =="
fd -a --glob ".github/workflows/*.yml" --glob ".github/workflows/*.yaml" | while read -r f; do
echo "--- $f ---"
rg -n "3\.10|3\.11|python-version|maturin|tox|nox|cibuildwheel" "$f" || true
doneRepository: tower/tower-cli
Length of output: 1064
🏁 Script executed:
# Find and inspect the workflow file
find .github/workflows -name "*.yml" -o -name "*.yaml" | head -20Repository: tower/tower-cli
Length of output: 514
🏁 Script executed:
# Read the build-binaries.yml workflow file to confirm the matrix versions
cat -n .github/workflows/build-binaries.yml | sed -n '65,75p; 110,120p; 163,173p; 211,221p; 260,270p; 311,321p; 350,360p'Repository: tower/tower-cli
Length of output: 3400
🏁 Script executed:
# Search for any other workflow files that may test Python 3.10/3.11
rg -l "python.*3\.10|python.*3\.11" .github/workflows/Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
# Check for tox, nox, or other test configuration files
find . -maxdepth 2 -type f \( -name "tox.ini" -o -name "noxfile.py" -o -name ".python-version" -o -name "setup.py" -o -name "setup.cfg" \) | head -20Repository: tower/tower-cli
Length of output: 77
🏁 Script executed:
cat -n .github/workflows/test-python.yml | head -100Repository: tower/tower-cli
Length of output: 1501
🏁 Script executed:
cat .python-versionRepository: tower/tower-cli
Length of output: 64
Declared Python support in packaging metadata does not match CI/build matrix.
pyproject.toml declares requires-python = ">=3.10" with classifiers for Python 3.10, 3.11, 3.12, 3.13, and 3.14. However, build-binaries.yml (lines 70, 115, 168) and all maturin invocations (lines 216, 265, 316, 355) only build and test wheels for 3.12–3.14. Additionally, .python-version is pinned to 3.12, and test-python.yml uses only that version. This means no Python 3.10/3.11 testing or wheel building occurs anywhere in CI.
Either update pyproject.toml to reflect requires-python = ">=3.12" (and remove 3.10/3.11 classifiers) if support is intentionally dropped, or add 3.10/3.11 to the test matrix in both build-binaries.yml and test-python.yml if those versions remain supported.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/build-binaries.yml at line 70, There is a mismatch between
the Python versions declared as supported in pyproject.toml (requires-python =
">=3.10" with classifiers for 3.10, 3.11, 3.12, 3.13, 3.14) and the versions
actually being built and tested in the CI workflows. The build-binaries.yml
python-version matrix only includes 3.12, 3.13, and 3.14 (at lines 70, 115, 168
and maturin invocations at lines 216, 265, 316, 355), and test-python.yml only
uses 3.12. Either update pyproject.toml to change requires-python to ">=3.12"
and remove the 3.10/3.11 classifiers if support for those versions is
intentionally dropped, or add Python 3.10 and 3.11 to the python-version matrix
in build-binaries.yml and test-python.yml workflows and update the
.python-version file to match the minimum supported version if those versions
should remain supported.
jo-sm
force-pushed
the
minimize-published-wheels
branch
2 times, most recently
from
2f52efb to
57f4159
Compare
Stop publishing wheels for Windows arm64 and Linux i686
jo-sm
force-pushed
the
minimize-published-wheels
branch
6 times, most recently
from
e04c741 to
7398711
Compare
Update pyproject.toml and uv.lock
jo-sm
force-pushed
the
minimize-published-wheels
branch
from
7398711 to
1d864d9
Compare
2 participants
This PR updates the build workflow to stop publishing wheels for the following:
Summary by CodeRabbit