Repository navigation
Copy configured guest files before agent bootstrap - #514
Conversation
|
Merge/readiness checklist for this PR: Stack order: #512 → #513 → #514 → #516. Each PR should ultimately merge into After a predecessor merges, retarget the next PR to
Validation clarification: this PR's original full Lima run had one SSH failure during the existing stub-Claude image build; that phase passed on an isolated retry without code changes. All six guest-file assertions passed. The complete downstream stack at #516 commit Use a clean checkout of this PR's final candidate and a Linux SSH host with working KVM/Firecracker access and the remote full-suite prerequisites. The full run needs the documented build/network tools and passwordless sudo. Run these suites serially on a shared host because they rebuild shared test images. git rev-parse HEAD
./tests/run-integration.sh --full --remote user@host --name coop-pr-514Replace Post the tested commit SHA, host architecture, runner exit status, pass/fail/skip counts, and a log link or attachment here. Inspect skipped phases; a zero exit alone is insufficient if relevant coverage was skipped. Linux CI does not substitute for Firecracker VM integration. A run of #516 alone provides combined-stack evidence, not proof that each earlier PR's exact candidate was tested. |
|
Review summary for I reviewed correctness, design, conventions, security, API usage, tests, docs, and code comments. I checked the pinned diff and post-change call paths, ran Current-head CI checks passed. I did not run Lima or Firecracker VM integration. The linked Firecracker full run exercised earlier commit |
db0f4c8 to
605ea4d
Compare
Add repeatable
[[guest_files]]mappings to copy explicit host files or directories into each VM before agent bootstrap. Copies refresh on restart, retain guest-only files, and use private owner-writable permissions.--no-agentsstill copies the configured files.Stage sources in private directories before VM startup or disk replacement. Allow source links only within declared roots, use descriptor-relative reads, and reject staging recursion, special files, destination overlaps or symlinks, and live-mount overlaps.
Update configuration examples and the configuration, command, architecture, trust, and testing references.
Stacked on #513.
Validation: workspace tests (1,200 coop, 30 proxy, and eight proxy integration), format, clippy, taplo, and normal pre-commit hooks passed. Mutation testing caught all 14 viable mutants (four unviable, none missed). Full Firecracker integration passed: 504 passed, zero failed, ten skipped.
The exact-candidate Lima run recorded 494 passed, one failed, and 13 skipped: an existing onboarding restart timed out waiting for SSH authentication. The unchanged isolated onboarding fixture then passed all eight checks. All six guest-file checks passed in the full attempt, and the complete combined stack at #516 subsequently passed full Lima integration (510 passed, zero failed, 13 skipped), including onboarding and all guest-file checks. The failed attempt remains recorded; it is not counted as a full pass.