Repository navigation
Flush Firecracker guests during graceful ARM64 shutdown - #533
Merged
Merged
Conversation
hbrodin
approved these changes
Oct 5, 2026
hbrodin
left a comment
hbrodin
left a comment
Collaborator
There was a problem hiding this comment.
The shutdown change looks good. Evan, please update the two Firecracker stop descriptions in docs/backends.md to say guest reboot over SSH before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request a guest reboot over SSH and wait for Firecracker to exit. Bound the graceful attempt to ten seconds, reap the SSH client, and retain SIGTERM/SIGKILL fallback when the guest does not stop. The command uses no forwarded guest environment.
This preserves recent filesystem changes on ARM64, where Firecracker rejects the CtrlAltDel API action. Add process-lifetime tests and an integration check for recent file writes and deletions.
Closes #528.
Stacked on #532, the disk-repair prerequisite. Merge #532 first.
Validation: local workspace tests, format, clippy, and normal pre-commit hooks passed. The unchanged shutdown implementation is included in the updated #513 candidate, which passed full Lima integration (490 passed) and full Firecracker integration (499 passed), including shutdown persistence checks.