Repository navigation
Remove devcontainer support - #535
Conversation
DarkaMaul
left a comment
There was a problem hiding this comment.
I had a similar branch so I mostly asked Codex to do a diff between this branch and mine.
The core removal looks sound, and the private-storage migration is a useful improvement: obsolete metadata is removed through checked directory descriptors without following symlinks. The integration coverage also verifies the important user-visible outcome—devcontainer.json remains ordinary workspace data while its environment and hook are ignored.
I found two compatibility/documentation gaps and one test-quality issue: preserve the --post-start reprovision caveat, pin deserialization of legacy template state containing oci_features, and make the removed-CLI test exhaustive and error-specific.
I reviewed correctness, design, conventions, security, tests, documentation, and changed comments. Focused CLI and migration tests passed. The full local suite encountered the same six environment-dependent failures in both compared implementations; I did not independently rerun the reported Lima and Firecracker integration suites.
Summary
coop devcontainercommand and related flags, remote repository lookup, and OCI Feature installation.Closes #525.
Verification
cargo build --workspacecargo fmt -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace(1,165 coop tests passed; 30 coop-proxy unit tests and 8 integration tests passed; one doc test ignored)cargo deny --workspace check,taplo format --check, andprek runcargo check -p coop --all-targets --target aarch64-apple-darwin