Skip to content

Fix duplicate padding in SingleShaMinHash sketches - #30

Merged
dhalf merged 3 commits into
mainfrom
fix/single-sha-distinct-bottom-k
Sep 30, 2026
Merged

dhalf merged 3 commits into
mainfrom
fix/single-sha-distinct-bottom-k

Conversation

@HunterDyerToB

Copy link
Copy Markdown

SingleShaMinHash selects the lowest k observation hashes before removing duplicates. Repeated low-hash rows can fill the signature, leaving the fingerprint unchanged when a distinct row is added. This patch selects the lowest k distinct hashes and adds regression tests at widths 4 and 400.

@CLAassistant

CLAassistant commented Sep 29, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dhalf
❌ Codex Agent


Codex Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dhalf
dhalf force-pushed the fix/single-sha-distinct-bottom-k branch from 67ca7b2 to 1d3647a Compare September 30, 2026 13:59
@dhalf
dhalf merged commit 0f4bea2 into main Sep 30, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants