Fix duplicate padding in SingleShaMinHash sketches - #30
Merged
Merged
Conversation
|
Codex Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dhalf
approved these changes
Sep 30, 2026
dhalf
force-pushed
the
fix/single-sha-distinct-bottom-k
branch
from
September 30, 2026 13:59
67ca7b2 to
1d3647a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SingleShaMinHash selects the lowest k observation hashes before removing duplicates. Repeated low-hash rows can fill the signature, leaving the fingerprint unchanged when a distinct row is added. This patch selects the lowest k distinct hashes and adds regression tests at widths 4 and 400.