Expand match_taxa branch coverage and fix aff. fuzzy reason text#283
Open
dfalster wants to merge 1 commit into
Open
Expand match_taxa branch coverage and fix aff. fuzzy reason text#283dfalster wants to merge 1 commit into
dfalster wants to merge 1 commit into
Conversation
Before refactoring the 54-branch match_taxa(), pin its behaviour:
- Fix malformed aligned_reason for fuzzy genus-level aff./affinis matches
(match_06b/06c/06d), which appended the date without a separating " (".
- Extend test_matches_alignments_updates.csv with inputs for the 7 match
branches no benchmark previously reached (03e/04e/06e/08e/12g/12h/12i)
and refresh the (previously unused) alignment_code column.
- Assert alignment_code in the alignment regression test.
- Add test-match_branches.R: dark-branch resolution, aligned_reason
well-formedness, and a full-output snapshot covering all match branches.
Full suite: 162 passed, 0 failed (resources version 2024-10-11).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
match_taxa()behaviour before refactoring the matcher.Changes
aligned_reasonfor fuzzy genus-levelaff./affinismatches (match_06b/06c/06d), which appended the date without a separating(— output was...genus-rank2026-..).test_matches_alignments_updates.csvwith inputs for the 7 match branches no benchmark previously reached (03e,04e,06e,08e,12g,12h,12i); now covers all 54 branches. Refreshed the previously-unusedalignment_codecolumn to real values.alignment_codein the alignment regression test (was selected but never checked — which is why the reason bug hid).test-match_branches.R: dark-branch resolution,aligned_reasonwell-formedness, and a full-output snapshot (_snaps/match_branches.md, date-normalised) covering all branches.Why
These tests are the safety net for the planned
match_taxa()de-duplication refactor (#279): a behaviour-preserving change leaves the snapshot + assertions green.Verification
Full suite: 162 passed, 0 failed (resources version
2024-10-11).Related: #279, #281
🤖 Generated with Claude Code