Subtree consistency tests with start > 0 - #257
Merged
Merged
Conversation
Update subtree consistency probe descriptions in cmd/proofgen/main.go to use end and size terminology rather than size1 and size2, and regenerate all corresponding JSON probe files under testdata/subtreeconsistency/. TAG=agy CONV=1f76bf92-7d8b-43a5-942a-a4bd88025626
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 46.57% 47.14% +0.57%
==========================================
Files 8 8
Lines 977 980 +3
==========================================
+ Hits 455 462 +7
+ Misses 511 508 -3
+ Partials 11 10 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
approved these changes
Jul 24, 2026
AlCutter
left a comment
AlCutter
left a comment
Collaborator
There was a problem hiding this comment.
I have no meaningful way of reviewing this, so... LGTM?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
This PR adds the last batch of tests for subtree consistency proofs. Hashes have been computed using the reference implementation.
This PR:
subtreeConsistencyProofinstead of relying on oldconsistencyProofsAdditional hashes were generated using the reference implementation functions, with code generated by Gemini: https://go.dev/play/p/WsdAyprmqlM. It makes sense for probes. Generating for reference_test.go with reference_test.go defeats a bit the purpose but... who knows how the existing tests were generated in the first place :).