[MTC] Improve MTC Log docs - #1143
Merged
Merged
Conversation
roger2hk
reviewed
Aug 26, 2026
Comment on lines
+30
to
+31
| - **`NewOptions()`**: Creates an `Options` builder to configure storage | ||
| backends, landmark intervals, maximum certificate lifetime, signers, and |
Contributor
There was a problem hiding this comment.
Update the text to indicate it is a landmarks storage backend. It's easy to get confused with Tessera storage backend.
Suggested change
| - **`NewOptions()`**: Creates an `Options` builder to configure storage | |
| backends, landmark intervals, maximum certificate lifetime, signers, and | |
| - **`NewOptions()`**: Creates an `Options` builder to configure landmarks storage | |
| backends, landmark intervals, maximum certificate lifetime, signers, and |
roger2hk
reviewed
Aug 26, 2026
|
|
||
| ### Main functionalities | ||
|
|
||
| See [mtc/log/README.md](../). |
Contributor
There was a problem hiding this comment.
Suggested change
| See [mtc/log/README.md](../). | |
| See [mtc/log/README.md](../README.md). |
roger2hk
reviewed
Aug 26, 2026
| This directory contains an MTC ([`draft-ietf-plants-merkle-tree-certs`](https://ietf-plants-wg.github.io/merkle-tree-certs/draft-ietf-plants-merkle-tree-certs.html)) | ||
| issuance log server backed by [Tessera's POSIX storage implementation](/storage/posix/). | ||
|
|
||
| This document contains [Documentation](#documentation), and a [Codelab](#codelab). |
Contributor
There was a problem hiding this comment.
Suggested change
| This document contains [Documentation](#documentation), and a [Codelab](#codelab). | |
| This document contains [Documentation](#documentation) and a [Codelab](#codelab). |
roger2hk
reviewed
Aug 26, 2026
| (e.g. 32473.106) | ||
| - `log_number`: The issuance log number (strictly positive). | ||
| - `private_key`: Location of private key file. If unset, uses the contents of | ||
| the LOG_PRIVATE_KEY environment variable. |
Contributor
There was a problem hiding this comment.
Suggested change
| the LOG_PRIVATE_KEY environment variable. | |
| the `LOG_PRIVATE_KEY` environment variable. |
roger2hk
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #945.