Add capability-review skill for in-chat advisory PR review#37
Merged
Conversation
Implements issue #23: the AI-advisory review of publish PRs (spec 004's duplicate-detection and boundary-quality analysis) now runs interactively via .agents/skills/capability-review/SKILL.md, reusing the rubric and output format from scripts/ci/ai_advisory_review.py. The CI job stays dormant per decision-log entries 19/25 — no workflow or script changes. README and CLAUDE.md (AGENTS.md's canonical target) note the review path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.agents/skills/capability-review/SKILL.md: the AI-advisory review of capability publish PRs (spec 004's duplicate-detection and boundary-quality analysis) now runs interactively in the reviewer's chat session, sinceANTHROPIC_API_KEYis intentionally not provisioned for CI (decision-log entries 19 and 25). The skill takes a PR number or contract path, loads the new contract plus compact summaries from the latestindex.jsonrelease (same input design asscripts/ci/ai_advisory_review.py), applies that script's rubric verbatim (one meaningful business action, not a CRUD wrapper/utility), and reportslikely_duplicatesandboundary_concernsin the script's exact comment format, stating explicitly that it is advisory and human judgment overrides it.Docs: README's publish flow and CLAUDE.md's key rules (AGENTS.md is a pointer to CLAUDE.md since #34) now describe the review path as deterministic CI + in-chat advisory skill + human approval.
Governing Spec
no-spec-needed (agent/session tooling, same category as registry-ops from #16; spec 004 remains the advisory function's normative home and its CI-side requirements are untouched)
Project Item
Definition of Done
scripts/ci/ai_advisory_review.py(named as the canonical wording in the skill) rather than a divergent second prompt.github/workflows/ci.ymlorscripts/ci/ai_advisory_review.py(decision 19 state preserved)Validation
traverse-starter/document-pipelinevs simulated publishedtraverse-starter/process): flagged as likely duplicate with the specific overlapacme/update-record, raw table-row update): flagged as boundary concern with reasoninggit diff --statconfirms only SKILL.md + two doc files touched