Skip to content

Add capability-review skill for in-chat advisory PR review#37

Merged
enricopiovesan merged 1 commit into
mainfrom
claude/issue-23-capability-review-skill
Jul 8, 2026
Merged

Add capability-review skill for in-chat advisory PR review#37
enricopiovesan merged 1 commit into
mainfrom
claude/issue-23-capability-review-skill

Conversation

@enricopiovesan

Copy link
Copy Markdown
Contributor

Summary

Adds .agents/skills/capability-review/SKILL.md: the AI-advisory review of capability publish PRs (spec 004's duplicate-detection and boundary-quality analysis) now runs interactively in the reviewer's chat session, since ANTHROPIC_API_KEY is intentionally not provisioned for CI (decision-log entries 19 and 25). The skill takes a PR number or contract path, loads the new contract plus compact summaries from the latest index.json release (same input design as scripts/ci/ai_advisory_review.py), applies that script's rubric verbatim (one meaningful business action, not a CRUD wrapper/utility), and reports likely_duplicates and boundary_concerns in the script's exact comment format, stating explicitly that it is advisory and human judgment overrides it.

Docs: README's publish flow and CLAUDE.md's key rules (AGENTS.md is a pointer to CLAUDE.md since #34) now describe the review path as deterministic CI + in-chat advisory skill + human approval.

Governing Spec

no-spec-needed (agent/session tooling, same category as registry-ops from #16; spec 004 remains the advisory function's normative home and its CI-side requirements are untouched)

Project Item

Definition of Done

  • Skill exists and is invocable in a chat session against a publish PR or contract path
  • Output covers likely duplicates (vs the latest published index) and boundary concerns with reasons, and states human judgment overrides it
  • Reuses the prompt rubric and output format from scripts/ci/ai_advisory_review.py (named as the canonical wording in the skill) rather than a divergent second prompt
  • README.md + CLAUDE.md (canonical target of AGENTS.md) note the review path: deterministic CI + in-chat advisory skill + human approval
  • Zero changes to .github/workflows/ci.yml or scripts/ci/ai_advisory_review.py (decision 19 state preserved)

Validation

Implements issue #23: the AI-advisory review of publish PRs (spec 004's
duplicate-detection and boundary-quality analysis) now runs interactively
via .agents/skills/capability-review/SKILL.md, reusing the rubric and
output format from scripts/ci/ai_advisory_review.py. The CI job stays
dormant per decision-log entries 19/25 — no workflow or script changes.
README and CLAUDE.md (AGENTS.md's canonical target) note the review path.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@enricopiovesan enricopiovesan merged commit 3bc49db into main Jul 8, 2026
6 checks passed
@enricopiovesan enricopiovesan deleted the claude/issue-23-capability-review-skill branch July 8, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add capability-review Claude skill for in-chat advisory PR review

1 participant