Fix newline output for empty stdin prompts - #1654
Open
ychampion wants to merge 1 commit into
Open
Conversation
Only terminate the password UI line when a prompt or feedback was displayed. This keeps stderr empty for promptless stdin authentication while preserving normal prompt cleanup. Fixes trifectatechfoundation#1648 Constraint: Preserve cleanup for visible prompts and password feedback Confidence: high Scope-risk: narrow Tested: cargo test prompt_ --release; cargo clippy --no-deps --all-targets -- --deny warnings; cargo fmt --all -- --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes done on this pull request
Password input cleanup now writes a trailing newline only when a prompt or feedback was displayed. This keeps
sudo -S -p ''stderr empty while preserving visible prompt cleanup.The regressions assert raw sink bytes because the compliance harness removes one trailing newline, and include a non-empty prompt control.
Fixes #1648.
Validation
cargo test prompt_ --releasecargo clippy --no-deps --all-targets -- --deny warningscargo fmt --all -- --checkPull Request Checklist
sudo -S -p ''writes a newline to stderr #1648, where the expected behavior and likely code path were documented.