Add NUMBER support#610
Open
lpoulain wants to merge 1 commit into
Open
Conversation
lpoulain
force-pushed
the
ENG-9425-add-NUMBER-support-to-python-client
branch
from
f91595b to
a875704
Compare
azawlocki-sbdt
suggested changes
Jun 25, 2026
azawlocki-sbdt
left a comment
azawlocki-sbdt
left a comment
Contributor
There was a problem hiding this comment.
I'd add some more tests for numeric literals, otherwise LGTM
Comment on lines
+41
to
+45
| def test_number_column_maps_value_to_decimal(self): | ||
| mapper = RowMapperFactory()._create_value_mapper(_column("number")) | ||
| result = mapper.map("10.3") | ||
| assert isinstance(result, Decimal) | ||
| assert result == Decimal("10.3") |
Contributor
There was a problem hiding this comment.
Please add test cases for exponential notation (positive and negative exponents) and negative literals.
Member
Author
There was a problem hiding this comment.
I've added some extra tests, including the NUMBER corner cases.
lpoulain
force-pushed
the
ENG-9425-add-NUMBER-support-to-python-client
branch
from
a875704 to
e4db914
Compare
Contributor
|
cc @findepi |
wendigo
approved these changes
Jun 26, 2026
findepi
reviewed
Jun 26, 2026
|
|
||
| def test_number_column_maps_infinity(self): | ||
| mapper = RowMapperFactory()._create_value_mapper(_column("number")) | ||
| assert mapper.map("Infinity") == Decimal("Infinity") |
Member
There was a problem hiding this comment.
Trino wire protocol uses "+Infinity" rather than "Infinity"
Add NUMBER support
lpoulain
force-pushed
the
ENG-9425-add-NUMBER-support-to-python-client
branch
from
e4db914 to
4131c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NUMBER support
Description
Support Trino NUMBER type by performing the following:
Non-technical explanation
Support Trino NUMBER type
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text:
Support Trino NUMBER type