Resolve decorated class through the container in initDecorated() - #8
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CacheDecorator::initDecorated()now resolves the decorated class through Laravel's service container (resolve($class)) instead ofnew $classwhen no instance is passed to the constructor.Why
The package is already Laravel-coupled (it uses the
Cache,Config, andLogfacades), and direct instantiation only worked for classes with a zero-argument constructor — it ignored the container entirely. Resolving through the container is a strictly-more-capable, low-risk upgrade:decoratedClass()may return an interface bound in the container.Changes
src/CacheDecorator.php—$decorated = new $class;→$decorated = resolve($class);. TheLogicExceptionnull-class guard is unchanged (it fires before the container is touched). Updated thedecoratedClass()PHPDoc.README.md/CLAUDE.md— documented container-based resolution per the README-sync convention.StubCollaborator,StubServiceWithDependency(requires the collaborator in its constructor), andCachedStubServiceWithDependency, plustest_decorated_class_is_resolved_through_container_with_dependencies. The service has a required constructor argument, so the oldnew $classpath would have thrownArgumentCountError— the test only passes because resolution auto-wires the dependency.Verification
composer test— 29 tests, 43 assertions, all green.🤖 Generated with Claude Code