Skip to content

feat: add runtime configuration fields docs - #1040

Open
harshil-2096 wants to merge 6 commits into
mainfrom
chore/hv/link-to-doc-pages-of-capabilities-in-runtimeconfig-section
Open

harshil-2096 wants to merge 6 commits into
mainfrom
chore/hv/link-to-doc-pages-of-capabilities-in-runtimeconfig-section

Conversation

@harshil-2096

@harshil-2096 harshil-2096 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes AGE-2386
image

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, python/trueforge_sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Presentation-only UI changes (external doc links and a small accessibility tweak) with no runtime config behavior changes.

Overview
Adds Learn more links (opens trueforge.dev in a new tab) on the agent Runtime Config form in detailed layout, so users can jump from each toggle to the matching docs.

Links are wired for dynamic sub-agents, generative UI, ask-user questions, iteration limit, sandbox, context compaction, and large tool response offloading via a shared RUNTIME_CONFIG_DOCS map and optional docsUrl on switch rows. Compact layout is unchanged.

Also adds an aria-label on the iteration limit input and replaces the iteration-limit <label> wrapper with a <div> so the doc link is not nested inside a label. A changeset records a patch for @truefoundry/trueforge-ui, and a unit test asserts each linked field’s href and target="_blank".

Reviewed by Cursor Bugbot for commit add8367. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: add8367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@harshil-2096
harshil-2096 marked this pull request as draft October 12, 2026 10:35
@harshil-2096
harshil-2096 marked this pull request as ready for review October 30, 2026 09:39
@qodex-ai

qodex-ai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Qodex review

(no summary)

Effort: ●●●○○ (3/5) · No findings worth raising. The diff reads clean.

Since last review: 0 addressed, 0 new.

Scope: the changes since the last review (delta: only what changed since the previously reviewed commit 0525c08 is reviewed; findings are anchored on the whole change).

Walkthrough
What Qodex checked

Lenses (openqodex review with checked answers, all dimensions)

  • Bugs and correctness
  • Security (auth, injection, SSRF, secrets, headers)
  • Performance regressions
  • Maintainability
  • Style and consistency

Scanners

  • Scanners (none fit the changed files)
  • 0 scanner candidates raised or dropped by the reviewer

Quality filters

  • PR description: adequate (present: length, checklist; missing: issue link)
  • Per-category confidence floor (bug/security/performance 0.7, maintainability 0.71, style 0.75)
  • Severity threshold from .qodex.yaml: minor
  • Path excludes (none configured in .qodex.yaml)
  • Disabled rules (none configured in .qodex.yaml)

Verification (M1b probes against PR preview)

  • Preview deployment discovered (no successful deploy for this commit)
  • Probes (skipped, no preview to probe)

Cross-review dedup

  • Delta review: delta: only what changed since the previously reviewed commit 0525c08 is reviewed; findings are anchored on the whole change
  • Carry-overs (no findings from earlier reviews still present)

Output

  • Walkthrough comment posted
  • Inline comments (no in-diff findings to attach)

Reviewer: 0 tool calls served, 0 model calls, 0 correction rounds, 0.0s. The library does not report tool calls asked apart from those it served, or a step cap.
Reviewed by Qodex · 6.3s

Every dimension is reviewed. Bugs, security, and performance post inline; low-severity style and convention notes are collected in the group above rather than dropped. Mark a finding resolved or flag a false positive in the Qodex Pull Requests view.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant