Repository navigation
feat: integrate react-query for caching and api calls - #1191
Open
harshil-2096 wants to merge 5 commits into
Open
harshil-2096 wants to merge 5 commits into
harshil-2096 wants to merge 5 commits into
Conversation
harshil-2096
requested review from
govindavashishtha and
sayan-truefoundry
as code owners
October 28, 2026 04:58
🦋 Changeset detectedLatest commit: e4ecb1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
harshil-2096
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
thesujai and
vinit-truefoundry
as code owners
October 28, 2026 04:58
…/react-query-server-client
…ore asserting presence of menu item
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e01952. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes AGE-2575
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes how capabilities are fetched and cached at the root of the UI tree; incorrect cache scoping on server swap could show wrong tenant flags, though new tests explicitly guard that path.
Overview
Introduces @tanstack/react-query in
@truefoundry/trueforge-uiwith a dedicated per-ServerProviderquery client (ServerQueryClientContext), so host apps are not required to wrap the UI inQueryClientProviderand their own React Query setup is not overridden.Capabilities loading in
ServerProvidermoves from manualuseEffect+ cancelable fetches touseQuerywithkeepPreviousDataon server swap (avoids gated UI flicker) andinvalidateQueriesfor refresh (failed refreshes still keep last known data). When theserverprop changes, the client is rescoped via a scopedqueryKeyHashFnso cached data from the previous server is never reused.Adds
queryClient.ts(defaults: 30s stale time, no focus/reconnect refetch or retries, explicit mount/unmount) and aqueryKeyscatalog for upcoming cached server reads. Bundles mark React Query as external; tests cover offline resume, isolated clients outsideServerProvider, server swap cache isolation, and a draft selector assertion that waits for capabilities after the async load change.Reviewed by Cursor Bugbot for commit 5e01952. Bugbot is set up for automated code reviews on this repo. Configure here.