Skip to content

bugfix: add Configure model button for empty catalog in composer - #1192

Merged
harshil-2096 merged 3 commits into
mainfrom
bugfix/hv/when-no-model-is-configured-we-show-a-symbol-next-to-select
Oct 29, 2026
Merged

harshil-2096 merged 3 commits into
mainfrom
bugfix/hv/when-no-model-is-configured-we-show-a-symbol-next-to-select

Conversation

@harshil-2096

@harshil-2096 harshil-2096 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes AGE-1899
image

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, python/trueforge_sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Composer-only empty-catalog UX and gating logic; no auth or data-path changes.

Overview
When the draft composer has no models after the catalog load finishes, and settings UI is available, DraftModelSelector now renders a standalone “Configure model” ghost button instead of the “Select model” dropdown (with its empty-state / ? monogram).

The CTA opens Settings on the models tab (with settings-open analytics when appropriate). Visibility now waits on loaded so the button does not flash during loading, and isSettingsChromeEnabled (catalog + capabilities) plus shell context—so hosts without settings chrome still get the normal picker and “No models” empty state. The in-panel settings link on DraftModelCatalogPanel was removed for this case.

Tests cover the new button, no flash while loading, disabled settings chrome, and unchanged behavior when no catalog is configured.

Reviewed by Cursor Bugbot for commit 4bfec37. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4bfec37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2a65cc3. Configure here.

…l button based on settings chrome availability
@harshil-2096
harshil-2096 enabled auto-merge (squash) October 29, 2026 09:47
@qodex-ai

qodex-ai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Qodex review

Reviewed units u1. Adds a patch changeset describing the empty-catalog button.

Effort: ●●●○○ (3/5) · No findings worth raising. The diff reads clean.

Scope: the whole pull request (no previous review: the whole change is reviewed).

Walkthrough

Notes

  • Code around the change is partial: 55 symbols cut at the packet byte cap.
What Qodex checked

Lenses (openqodex review with checked answers, all dimensions)

  • Bugs and correctness
  • Security (auth, injection, SSRF, secrets, headers)
  • Performance regressions
  • Maintainability
  • Style and consistency

Scanners

  • actionlint did not run
  • bandit did not run
  • brakeman did not run
  • cargo-deny did not run
  • checkov did not run
  • gitleaks 8.21.2
  • golangci did not run
  • hadolint did not run
  • kube-linter did not run
  • kubeconform did not run
  • osv-scanner 2.6.0
  • oxlint 1.86.0
  • rubocop did not run
  • ruff did not run
  • semgrep 1.94.0
  • shellcheck did not run
  • sqlfluff did not run
  • sqllint did not run
  • squawk did not run
  • tflint did not run
  • trivy did not run
  • zizmor did not run
  • 0 scanner candidates raised or dropped by the reviewer

Quality filters

  • PR description: adequate (present: length, checklist; missing: issue link)
  • Per-category confidence floor (bug/security/performance 0.7, maintainability 0.71, style 0.75)
  • Severity threshold from .qodex.yaml: minor
  • Path excludes (none configured in .qodex.yaml)
  • Disabled rules (none configured in .qodex.yaml)

Verification (M1b probes against PR preview)

  • Preview deployment discovered (no successful deploy for this commit)
  • Probes (skipped, no preview to probe)

Cross-review dedup

  • Full review: no previous review: the whole change is reviewed
  • Carry-overs (no findings from earlier reviews still present)

Output

  • Walkthrough comment posted
  • Inline comments (no in-diff findings to attach)

Reviewer: shown 14 of 14 changed hunks, opened 10 files (1 changed file never opened), 25 tool calls served, 8 model calls, 0 correction rounds, 32.5s. The library does not report tool calls asked apart from those it served, or a step cap.
Reviewed by Qodex · 64.5s

Every dimension is reviewed. Bugs, security, and performance post inline; low-severity style and convention notes are collected in the group above rather than dropped. Mark a finding resolved or flag a false positive in the Qodex Pull Requests view.

@harshil-2096
harshil-2096 merged commit 218c95e into main Oct 29, 2026
16 checks passed
@harshil-2096
harshil-2096 deleted the bugfix/hv/when-no-model-is-configured-we-show-a-symbol-next-to-select branch October 29, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants