Repository navigation
bugfix: add Configure model button for empty catalog in composer - #1192
harshil-2096 merged 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 4bfec37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a65cc3. Configure here.
…l button based on settings chrome availability
…w-a-symbol-next-to-select
Qodex reviewReviewed units u1. Adds a patch changeset describing the empty-catalog button. Effort: ●●●○○ (3/5) · No findings worth raising. The diff reads clean. Scope: the whole pull request (no previous review: the whole change is reviewed). WalkthroughNotes
What Qodex checkedLenses (openqodex review with checked answers, all dimensions)
Scanners
Quality filters
Verification (M1b probes against PR preview)
Cross-review dedup
Output
Reviewer: shown 14 of 14 changed hunks, opened 10 files (1 changed file never opened), 25 tool calls served, 8 model calls, 0 correction rounds, 32.5s. The library does not report tool calls asked apart from those it served, or a step cap. Every dimension is reviewed. Bugs, security, and performance post inline; low-severity style and convention notes are collected in the group above rather than dropped. Mark a finding resolved or flag a false positive in the Qodex Pull Requests view. |

Summary
Closes AGE-1899

Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Composer-only empty-catalog UX and gating logic; no auth or data-path changes.
Overview
When the draft composer has no models after the catalog load finishes, and settings UI is available,
DraftModelSelectornow renders a standalone “Configure model” ghost button instead of the “Select model” dropdown (with its empty-state / ? monogram).The CTA opens Settings on the models tab (with settings-open analytics when appropriate). Visibility now waits on
loadedso the button does not flash during loading, andisSettingsChromeEnabled(catalog + capabilities) plus shell context—so hosts without settings chrome still get the normal picker and “No models” empty state. The in-panel settings link onDraftModelCatalogPanelwas removed for this case.Tests cover the new button, no flash while loading, disabled settings chrome, and unchanged behavior when no catalog is configured.
Reviewed by Cursor Bugbot for commit 4bfec37. Bugbot is set up for automated code reviews on this repo. Configure here.