-
Notifications
You must be signed in to change notification settings - Fork 10
Gear for OpenShift CI #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jakob-Naucke
merged 14 commits into
trusted-execution-clusters:main
from
Jakob-Naucke:openshift-ci
Jun 26, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c1014e9
make: Do not track Kind Azure host
Jakob-Naucke 0d54f6e
Revert "ci: Avoid cargo for retrieving kopium version"
Jakob-Naucke 5a1d5b4
Fix `v` in image tag version
Jakob-Naucke 57371ed
tests: Fix a missing platform kubectl usage
Jakob-Naucke e93e573
tests: Use await_condition instead of polling
Jakob-Naucke 5deacf3
tests: Move kubectl() out of K8sPlatform
Jakob-Naucke a759568
tests: Make client & ns part of K8sPlatform
Jakob-Naucke d87721f
tests: Expose OpenShift services with LB services
Jakob-Naucke 0ef3155
rbac: Fix finalizers for OpenShift
Jakob-Naucke 0d96c00
make: ?= OPERATOR_IMAGE
Jakob-Naucke 16376ae
tests/azure: Pass Ignition as user-data
Jakob-Naucke f191dd3
Requeue upon failed component installation
Jakob-Naucke eb2a7cb
tests: Wait for custom resources to remove
Jakob-Naucke 3c1f11e
tests: Wait for services
Jakob-Naucke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: The new KOPIUM_VERSION detection adds a hard dependency on
jqand a relatively complexcargo metadataquery.This approach is more robust than grepping
Cargo.toml, but it now relies onjqbeing available everywhere the Makefile runs and on the stability of thecargo metadatalayout. If that’s not guaranteed (e.g., minimal CI images, some dev setups), please either document/enforce thejqrequirement with a clear failure message, or simplify how the version is resolved (e.g., restrict the query scope or move the logic into a small helper script/binary) to reduce fragility.Suggested implementation:
If the Makefile already defines a
JQvariable elsewhere (not visible in the provided snippet), you should remove one of the definitions or consolidate them to avoid redefinition. Otherwise, this change will:jqis missing andKOPIUM_VERSIONis not provided.jqrequirement by explicitly supplyingKOPIUM_VERSIONon the command line or in the environment.