release: promote main - #90
Open
github-actions[bot] wants to merge 3 commits into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…results (#92) Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything on
mainthatreleasedoes not have yet. Merging this is what puts it infront of users, because
releaseis what a deploy and a plain clone both point at.Merge #91 chore(main): release 1.5.0 first. It is the release pull request: it writes the changelog, bumps the version and cuts the tag on
main. Merge it before this one and the tag lands on a commitreleasereceives. Merge this one first and you ship the code untagged, and the version does not reachreleaseuntil the next promotion.Merge it with a merge commit, not a squash: a squash would give
releasea newcommit of its own, and the tags on
mainwould stop being ancestors of what you shipped.