fix: eager-load workspace.account in SocialAccountObserver to prevent lazy loading crash - #259
Merged
paulocastellano merged 2 commits intoAug 9, 2026
Conversation
… lazy loading crash Closes #255
…y-loading protection Reflects that SocialAccountObserver::notifyOnboarding() now self-heals via loadMissing().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SocialAccountObserver::notifyOnboarding()read$socialAccount->workspace?->accountwithout eager-loadingworkspace, which lazy-load-strict mode rejects onceBuilder::hydrate()batches 2+ distinctSocialAccountrows in the same query (only then does it flippreventsLazyLoadingon the models).notifyOnboarding()now calls$socialAccount->loadMissing('workspace.account')before touching the relation, so no caller needs to remember to eager-load it.SocialAccountrows in one query and updates each — reproducesLazyLoadingViolationExceptionbefore the fix, passes after.Closes #255
Test plan
php artisan test --compact tests/Feature/Observers/SocialAccountObserverTest.php— 5 passedphp artisan test --compact --parallel --filter="Observers|VerifyUpcomingPostConnections"— 48 passedvendor/bin/pint --dirty --format agent— clean