🔒 Fix hardcoded database credentials and SQL injection vulnerabilities - #28
🔒 Fix hardcoded database credentials and SQL injection vulnerabilities#28tsainez wants to merge 1 commit into
Conversation
Replaced hardcoded PDO credentials in `doLogin.php` and `addUser.php` with `getenv()` to securely load configuration. Also updated both files to use parameterized statements to prevent SQL injection vulnerabilities. Fixed syntax errors in `addUser.php`'s INSERT query. Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Hardcoded database credentials were found in
php/cookies_and_access_control/doLogin.phpandphp/cookies_and_access_control/addUser.php. In addition, SQL injection vulnerabilities were present in both files due to direct concatenation of user input into SQL queries.🛡️ Solution: Modified the files to retrieve database connection details (
host,db,username,password) securely via environment variables usinggetenv(). Additionally, updated the PDO database interactions to use parameterized prepared statements, completely mitigating the SQL injection risks. Fixed a minor syntax error inaddUser.php's INSERT statement where single quotes were incorrectly used around table and column names.PR created automatically by Jules for task 14814758747756920596 started by @tsainez