Skip to content

🔒 Fix Plaintext Password Storage in PHP Auth - #30

Open
tsainez wants to merge 1 commit into
masterfrom
security-fix-password-hash-2432010758284729814
Open

🔒 Fix Plaintext Password Storage in PHP Auth#30
tsainez wants to merge 1 commit into
masterfrom
security-fix-password-hash-2432010758284729814

Conversation

@tsainez

@tsainez tsainez commented Jul 14, 2026

Copy link
Copy Markdown
Owner

🎯 What: Fixed a critical security vulnerability where passwords were being stored and compared in plaintext during the login and registration process.

⚠️ Risk: Storing plaintext passwords exposes user accounts to severe compromise if the database is leaked or accessed by an unauthorized actor. Attackers could easily view and misuse the plaintext passwords across this and other services if users reuse credentials.

🛡️ Solution:

  • Updated addUser.php to hash passwords securely upon registration using password_hash() with PASSWORD_DEFAULT.
  • Updated doLogin.php to securely verify logins using password_verify() against the stored hash instead of performing strict string equality comparison.
  • Updated lab10.sql to expand the password field from varchar(50) to varchar(255) to accommodate modern, longer password hashes, and updated the seed data to use a valid hashed password.
  • Additionally upgraded the database queries in both PHP files to utilize PDO prepared statements with parameter binding, securing the application against SQL injection vulnerabilities.

PR created automatically by Jules for task 2432010758284729814 started by @tsainez

Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant