🔒 Fix SQL Injection vulnerabilities in Quiz_4.py - #37
Conversation
Replaced string formatting with parameterized queries in insertPC, updatePrinter, and deleteLaptop functions to properly sanitize inputs and prevent SQL injection. Added unit tests using an in-memory SQLite database to ensure the methods still work correctly and prevent future regressions. Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The vulnerability fixed
Addressed SQL injection vulnerabilities within
python/Quiz_4.py. TheinsertPC,updatePrinter, anddeleteLaptopfunctions were previously building SQL queries using string formatting (.format()), which allows attackers to manipulate the SQL statements and exploit the database.Unsanitized string formatting in SQL commands allows for SQL injection (SQLi). An attacker could pass malformed input values that modify the SQL syntax. This could lead to unauthorized data access, arbitrary data modification, or complete database deletion, severely compromising application security and data integrity.
🛡️ Solution: How the fix addresses the vulnerability
The raw
.format()string queries were replaced with parameterized queries utilizing SQLite's?placeholder execution system. This approach securely escapes the input data, treating it strictly as data rather than executable code, thereby neutralizing the SQL injection vector. Additionally, a new unit test suite (python/test_Quiz_4.py) was introduced utilizing an in-memory SQLite database to verify the correctness of the updated functions.PR created automatically by Jules for task 16483888372219575899 started by @tsainez