Skip to content

Fix TODO for compute coef_train for all training images - #44

Open
tsainez wants to merge 1 commit into
masterfrom
fix-matlab-eigenface-coef-13579861664170823562
Open

Fix TODO for compute coef_train for all training images#44
tsainez wants to merge 1 commit into
masterfrom
fix-matlab-eigenface-coef-13579861664170823562

Conversation

@tsainez

@tsainez tsainez commented Jul 14, 2026

Copy link
Copy Markdown
Owner

The lab11.m file contained a TODO comment indicating that the training coefficients coef_train needed to be computed for all training images. The placeholder line %coef_train = zeros(k, n_train); was commented out, and immediately followed by coef_train = U'*Y; which mathematically computes the correct k x n_train coefficient matrix. This commit simply removes the obsolete TODO comment and commented out zero-initialization line.


PR created automatically by Jules for task 13579861664170823562 started by @tsainez

Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant