Skip to content

🔒 Fix SQL Injection in saveUserDatav2 and getRecordById #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsainez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔒 Fix SQL Injection in saveUserDatav2 and getRecordById #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions php/binary_data/user-1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,43 @@
<?php
public function saveUserDatav2() {
parent::connect_to_database("localhost", "barreto", "sTovok0r", "movieCollection");
$queryStr = "INSERT INTO 'users'('userID', 'fname', 'lname', 'pic')"."VALUES (NULL, '".$this->fname."', '".$this->lname."', '".$this->profilePic."')";
echo $queryStr;
$result = parent::executeQuery($queryStr);
if ($result === TRUE) {
$uid = parent::returnLastRecordID();
$success = $uid;
} else {
$success = FALSE;
}
class users extends database {
public $fname;
public $lname;
public $profilePic;
public $email;
public $password;
public $userid;

parent::disconnect_from_database();
return $success;
}
public function saveUserDatav2() {
parent::connect_to_database("localhost", "barreto", "sTovok0r", "movieCollection");
$queryStr = "INSERT INTO `users` (`userID`, `fname`, `lname`, `pic`) VALUES (NULL, ?, ?, ?)";
$params = [$this->fname, $this->lname, $this->profilePic];
$result = parent::executeQuery($queryStr, $params);

public function getRecordById($myid) {
parent::connect_to_database("localhost", "barreto", "sTovok0r", "movieCollection");
$queryStr = "SELECT * FROM 'users' WHERE 'userID' = ".$myid;
parent::executeQuery($queryStr);
$profileInfo = parent::getResultSet();
$this->userid = $profileInfo['userID'];
$this->fname = $profileInfo['fname'];
$this->lname = $profileInfo['lname'];
$this->profilePic = $profileInfo['pic'];
$this->email = $profileInfo['email'];
$this->password = crypt($profileInfo['password'],"sdjeyrfgdb4334");
parent::disconnect_from_database();
}
if ($result === TRUE) {
$uid = parent::returnLastRecordID();
$success = $uid;
} else {
$success = FALSE;
}

parent::disconnect_from_database();
return $success;
}

public function getRecordById($myid) {
parent::connect_to_database("localhost", "barreto", "sTovok0r", "movieCollection");
$queryStr = "SELECT * FROM `users` WHERE `userID` = ?";
$params = [$myid];
parent::executeQuery($queryStr, $params);
$profileInfo = parent::getResultSet();
$this->userid = $profileInfo['userID'];
$this->fname = $profileInfo['fname'];
$this->lname = $profileInfo['lname'];
$this->profilePic = $profileInfo['pic'];
$this->email = $profileInfo['email'];
$this->password = crypt($profileInfo['password'],"sdjeyrfgdb4334");
parent::disconnect_from_database();
}

// Getter methods from the users class

Expand All @@ -47,7 +57,8 @@ public function getEmail() {
return $this->email;
}

public function getPassword() {
return $this->password;
public function getPassword() {
return $this->password;
}
}
?>