Skip to content

Fix test image projection formula in lab11.m - #51

Open
tsainez wants to merge 1 commit into
masterfrom
fix-matlab-eigenface-projection-11243763330961440179
Open

Fix test image projection formula in lab11.m#51
tsainez wants to merge 1 commit into
masterfrom
fix-matlab-eigenface-projection-11243763330961440179

Conversation

@tsainez

@tsainez tsainez commented Jul 14, 2026

Copy link
Copy Markdown
Owner

What:
Fixed the test coefficients computation formula in matlab/lab11.m and resolved the outstanding TODO.

Why:
The previous logic overwrote the original test image shape array (img_test) with a 1D vector during mean subtraction before applying the projection. The new approach uses a single matrix multiplication line coef_test = U' * (img_test(:) - x_bar); that safely calculates the projection without destroying the test image variable.

How:

  • Replaced the two lines handling mean subtraction and projection calculation with a single inline transformation.
  • Validated via mocked structural test datasets to ensure mathematical parity and correct dimensions are preserved.
  • Maintained backward compatibility with existing Eigenfaces classification implementation (accuracy scores intact).

PR created automatically by Jules for task 11243763330961440179 started by @tsainez

Replaced the dual-line extraction and projection process with a single cohesive mathematical formula: `coef_test = U' * (img_test(:) - x_bar)`. This updates the code structure to correctly calculate the PCA projection coefficients while preserving the unmodified testing images and resolving the TODO comment.

Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant