fix: manualEdits position double-counts parent group's anchor (#2281)

[sagarmaurya64-ai]

This PR resolves #2281 where manual placement coordinates inside a positioned group or translated subcircuit were double-counting the parent group's/subcircuit's translation.

Cause

In PrimitiveComponent.ts, manualPlacement coordinates (retrieved via getSubcircuit()._getPcbManualPlacementForComponent(this)) are already subcircuit-absolute (meaning the subcircuit's global transform has already been pre-multiplied).
However, _computePcbGlobalTransformBeforeLayout() composed this with this.parent?._computePcbGlobalTransformBeforeLayout(), adding the parent's translation offset a second time.

Fix

Composed the manual placement coordinate with only the parent's global rotation (extracted using decomposeTSR on the parent global transform), rather than the entire parent global transform.

Testing

• Created a standard unit test file tests/repro-2281.test.tsx verifying the positioning offset behaves correctly both in plain positioned groups and in rotated parent groups.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tscircuit-core-benchmarks	Ready	Preview, Comment	Jun 7, 2026 9:54am

[github-actions]

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

[github-actions]

This PR was closed because it has been inactive for 1 day since being marked as stale.