Skip to content

Add pcb silkscreen graphic support#2415

Open
techmannih wants to merge 2 commits into
tscircuit:mainfrom
techmannih:silkscreen-graphic-circuit-json-1
Open

Add pcb silkscreen graphic support#2415
techmannih wants to merge 2 commits into
tscircuit:mainfrom
techmannih:silkscreen-graphic-circuit-json-1

Conversation

@techmannih

Copy link
Copy Markdown
Member

Summary

  • add a SilkscreenGraphic primitive component for BRep-based PCB silkscreen graphics
  • teach createComponentsFromCircuitJson to reconstruct pcb_silkscreen_graphic elements from circuit JSON
  • cover the round-trip with a PCB snapshot test

Why

  • allow circuit-json silkscreen graphics to round-trip back into core components

Impact

  • users can import BRep silkscreen graphics from circuit JSON and render them through the existing PCB snapshot flow

Validation

  • bun test tests/utils/createComponentsFromCircuitJson/pcb-silkscreen-graphic-snapshot.test.tsx
  • bunx tsc --noEmit

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Jun 11, 2026 5:02am

Request Review

@techmannih techmannih marked this pull request as ready for review June 11, 2026 11:21
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a fast-xml-parser to parse the imported SVG image so we can extract its shapes, transforms, and fill rules, convert them into paths/polygons, and then generate internal BRep pcb_silkscreen_graphic geometry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant