Fix GoReleaser workflow for pull requests - #7
Merged
Conversation
Run snapshot releases with read-only permissions for pull requests and reserve write-enabled releases for tags. Upgrade CI to Go 1.27.1 and GoReleaser Action v7 with CLI v2. Co-Authored-By: Codex (gpt-5.6-sol) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The existing workflow runs
goreleaser release --cleanfor pull request merge commits. Those commits are not version tags, so GoReleaser exits before building with an error such as:git tag v1.1.2 was not made against commit ...Snapshot mode removes the tag requirement while still building and packaging every supported target. Formal publishing remains restricted to tag pushes.
Validation
actionlint .github/workflows/release.ymlGOTOOLCHAIN=go1.27.1 go test -count=1 -race ./...GOTOOLCHAIN=go1.27.1 go vet ./...goreleaser release --snapshot --cleanwith GoReleaser v2.18.0gitleaksscan of the resulting commit (no leaks found)