Skip to content

Bump TerminalGuiVersion to 2.4.14-develop.28 (needs fixes) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tig wants to merge 1 commit into from
Closed

Bump TerminalGuiVersion to 2.4.14-develop.28 (needs fixes) #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
Override per-build via -p:TerminalGuiVersion=<x>; use -p:UseLocalTerminalGui=true
to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets).
-->
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.2</TerminalGuiVersion>
<TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.28</TerminalGuiVersion>

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the dependency pin on a buildable version

With this default changed to 2.4.14-develop.28, the repository no longer builds as-is: the bump workflow for this exact version failed during dotnet build with obsolete API diagnostics promoted by <TreatWarningsAsErrors>true</TreatWarningsAsErrors> (for example the ConfigurationProperty/SettingsScope usage in src/Terminal.Gui.Editor/Editor.Commands.cs#L24, plus the ted settings usages). Since every normal restore/build now consumes this pin unless overridden, this needs the corresponding source migration or the pin should stay on the previous green version.

Useful? React with 👍 / 👎.

</PropertyGroup>

<ItemGroup>
Expand Down
Loading