Bump TerminalGuiVersion to 2.4.14-beta.1 (needs fixes)#262
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94b64430c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.2</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-beta.1</TerminalGuiVersion> |
There was a problem hiding this comment.
Make the Terminal.Gui bump buildable
With this default pin, the repo no longer builds under the validation path because Directory.Build.props:8 treats warnings as errors and Terminal.Gui 2.4.14-beta.1 marks the configuration APIs used here as obsolete; the failed bump workflow reports errors for SettingsScope/ConfigurationPropertyAttribute usages such as src/Terminal.Gui.Editor/Editor.Commands.cs:24 and the examples/ted/EditorSettings.cs properties. Since CI and normal restores use this default TerminalGuiVersion, the dependency bump needs the accompanying source/configuration migration or suppression before landing.
Useful? React with 👍 / 👎.
|
Superseded by #264 (merged): develop is now migrated to Terminal.Gui's MEC config path and pinned to stable 2.4.15, which resolves the CS0618 build break these auto-bump PRs hit. Closing and deleting the branch. |
Automated bump of
TerminalGuiVersionfrom2.4.14-develop.2to2.4.14-beta.1failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.