Repository navigation
render: move the template to SQLFlow v2026.09.21, with a turbostats block off unless set - #362
Merged
Merged
Conversation
From v2026.09.19.1. v2026.09.21 carries the TurboStats reporter, so an install can report itself to a control plane once its configs carry a turbostats block; the configs do not change here, and reporting stays off. Six references carry the tag and move together, or the template builds one engine and tests another: the Dockerfile's ARG, the Makefile, three compose build args and the e2e's default. The README's two sample telemetry payloads and the version comment in bin/telemetry.sh name it too. Evidence: make -C render validate passes, and make -C render test passes against the new image, 88 checks. It ran as its own compose project on spare ports, because another stack of this template held the default ones. If the bump is wrong, a Deploy to Render install fails its health check on first deploy.
v2026.09.21 can report an install to a control plane, but only from a
turbostats block in the config; an environment variable alone turns
nothing on. The template had no block, so no install of it could report.
pipeline.yml and serve.yml gain one, read from SQLFLOW_TURBOSTATS_REPORT_TO,
SQLFLOW_TURBOSTATS_KEY and SQLFLOW_TURBOSTATS_ID. report_to defaults to
empty, which the engine reads as reporting nowhere, and skips the key and
id checks. An install that sets nothing runs exactly as before, and
render.yaml does not declare the variables, so a Deploy to Render user is
never asked about a control plane.
The values are quoted. Unquoted, an unset variable renders as null, which
the pipeline schema accepts and the serve schema rejects ("got null, want
string"). The block needs v2026.09.21: v2026.09.19.1 rejects it as an
additional property, which is why it ships with the engine bump.
Evidence: make -C render validate passes; with the variables set, both
configs check the key, which proves the block is read; make -C render
test passes, 88 checks, with reporting off. If this is wrong, an install
fails validation at startup, or reports where nobody asked it to.
turbolytics
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Deploy to Render template's engine from v2026.09.19.1 to v2026.09.21, and gives its configs a
turbostatsblock that stays off unless set.Changes:
ARG, the Makefile, three compose build args and the e2e's default. The README's sample payloads and a comment inbin/telemetry.shmove too.pipeline.ymlandserve.ymlread it fromSQLFLOW_TURBOSTATS_REPORT_TO,SQLFLOW_TURBOSTATS_KEYandSQLFLOW_TURBOSTATS_ID. An emptyreport_to, the default, reports nowhere and skips the key check. An install that sets nothing runs as before.render.yaml: a Deploy to Render user is never asked about a control plane.Testing:
make -C render validatepasses.make -C render testpasses with reporting off: 88 checks.