Skip to content

[pull] master from ruby:master #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Apr 24, 2026
+9 −4
Merged

[pull] master from ruby:master #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/prism/translation/ripper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ module Translation
# - on_comma
# - on_ignored_nl
# - on_ignored_sp
# - on_label_end
# - on_nl
# - on_operator_ambiguous
# - on_semicolon
Expand Down Expand Up @@ -3633,7 +3632,13 @@ def visit_string_node(node)
end

result = yield
return result if assoc
if assoc
if node.closing != ":"
bounds(node.closing_loc)
on_label_end(node.closing)
end
return result
end

if is_heredoc
bounds(node.closing_loc)
Expand Down
4 changes: 2 additions & 2 deletions test/prism/ruby/ripper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,11 @@ def test_lex_ignored_missing_heredoc_end
end
end

UNSUPPORTED_EVENTS = %i[comma ignored_nl label_end nl semicolon sp ignored_sp]
UNSUPPORTED_EVENTS = %i[comma ignored_nl nl semicolon sp ignored_sp]
# Events that are currently not emitted
SUPPORTED_EVENTS = Translation::Ripper::EVENTS - UNSUPPORTED_EVENTS
# Events that assert against their line/column
CHECK_LOCATION_EVENTS = %i[kw op lbrace rbrace lbracket rbracket lparen rparen words_sep]
CHECK_LOCATION_EVENTS = %i[kw op lbrace rbrace lbracket rbracket lparen rparen words_sep label_end]

module Events
attr_reader :events
Expand Down