Port EspoCRM appliance to TurnKey 19 - #23
Open
lirazsiri wants to merge 6 commits into
Open
Conversation
Install the current supported EspoCRM 10.0.6 release on PHP 8.4 and verify the official release digest during the build. Update firstboot password handling for EspoCRM's bcrypt format and keep the database account scoped to its application database. Add functional acceptance coverage for firstboot login, lead creation and persistence, cron, WebSocket, administration packages, and the supervised upstream update channel. Static shell and Python checks pass.
Debian Trixie no longer provides php-imap, so retaining the v18 plan entry prevents appliance builds. EspoCRM 10.0.6 does not declare the extension as a requirement and contains no calls to its removed PHP functions, while its supported bundled mail stack remains available.
Read the complete SPA response before searching it so curl is not terminated by grep under pipefail, and assert EspoCRM 10's actual administrator type field. These changes align the acceptance test with the verified fixture responses without changing appliance behavior.
The shared Docker acceptance preseed configures APP_DOMAIN as localhost. Exercise HTTPS and verify EspoCRM's site URL against that actual firstboot input so the test validates the appliance contract rather than a different fixture hostname.
The shared runtime reached a healthy first boot but the acceptance script exited during silent prerequisite assertions before exercising authentication. Remove redundant PHP and Apache implementation probes, since the HTTPS application and CRM workflow provide stronger functional evidence, and retain concise diagnostics for the service and identity checks that remain. Verification: bash -n tests/v19.sh; git diff --check.
EspoCRM 10 stores siteUrl in data/config.php, so the inherited firstboot rewrite of config-internal.php completed without changing the live identity. Use the upstream-supported config:set command as www-data and query the same interface in acceptance testing. This preserves the configured firstboot domain across EspoCRM's current config format. Verification: bash syntax checks; Python byte compilation; git diff --check. The retained full run 20260825t091807z-1660-9617 identified the pre-fix mismatch after successful build, import, boot, firstboot, and HTTPS application response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
9623bf120260826t035742z-371-29726476558d18fb8b482463df324132730807dc4aa60b0860ab944552acda65b0753, and run log verifiedgit diff --check origin/master...9623bf1