Keep Postfix stopped during rootfs configuration - #379
Open
lirazsiri wants to merge 1 commit into
Open
Conversation
Validate the generated Postfix configuration without starting its master process while an appliance root filesystem is being assembled. This avoids colliding with an existing build-host listener on port 25 and leaves normal service startup to the enabled systemd unit after boot. Add a focused fixture that holds port 25 open, verifies the listener survives configuration, requires postmulti check and service enablement, and fails if the Postfix command starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
tests/test-postfix-local-build.shin LibreSBX as root with TCP port 25 occupied/usr/sbin/postmulti -p check, followed by an assertion that nomasterprocess existsbash -n conf/turnkey.d/postfix-local tests/test-postfix-local-build.shgit diff --check b60dd230..650ae31