Skip to content

feat(security): enable Windows WebView2 password autosave - #1400

Merged
tw93 merged 3 commits into
tw93:mainfrom
WavesMan:feature/auto-save-account
Oct 5, 2026
Merged

tw93 merged 3 commits into
tw93:mainfrom
WavesMan:feature/auto-save-account

Conversation

@WavesMan

Copy link
Copy Markdown
Contributor

PR Description

Summary

Enable native WebView2 password saving and autofill for Pake apps on Windows.

Changes

  • Add the --password-autosave CLI option and passwordAutosave config field
  • Enable IsPasswordAutosaveEnabled on the app鈥檚 WebView2 Profile
  • Disable password persistence when incognito mode is enabled
  • Keep credentials isolated from Chrome and Edge profiles
  • Update CLI schema, documentation, generated CLI output, and snapshots
  • Add the required WebView2 COM interface dependency

Verification

  • Rust cargo check
  • Rust formatting check
  • CLI configuration tests: 26 passed
  • Windows application build completed successfully

Limitations

This uses the app-specific WebView2 Profile. It does not access Chrome/Edge password stores, account sync, Windows
PIN, or Windows Hello verification.

@tw93

tw93 commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

@WavesMan Thanks for the contribution. It is merged and shipped in pake-cli 3.17.3 as the opt-in Windows flag --password-autosave. I also made the off state explicit, so autosave is turned off on every window when the flag is absent and always off in private windows.

Saved passwords stay in that app's own WebView2 profile and are not shared with Edge or Chrome. Run npm install -g pake-cli@3.17.3 and rebuild with --password-autosave to use it.

tw93 added 2 commits October 5, 2026 08:22
Apply both opt-in and opt-out settings to every Windows webview, suppress new saves in private mode, and use the older supported Settings4 interface. Clarify that disabling save prompts does not erase existing passwords or prevent their autofill. Sync the contributor branch with main and retain current tab behavior.
Check the deserialized flag separately from private-mode suppression so the regression test covers the legacy configuration default.
@tw93
tw93 merged commit e12768b into tw93:main Oct 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants