ci(codegen): render with released tx3c and smoke-check the surface - #12
Merged
Merged
Conversation
Provision tx3c through tx3-lang/actions/setup (stable: tx3c 0.25.0) instead of building a pinned pre-release commit, and move the check into .github/scripts/codegen-check.sh. It now asserts the generated surface (identity constants, Profile, TIR constants, Params records, typed party setters, no builder-only setters) before compiling against this checkout, as sdk-spec codegen/testing.md requires. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
codegenjob built tx3c from tx3 commit456f685(pre-release) and only compiled the output. The SDK spec (sdk-spec/codegen/testing.md) requires tx3c fromtx3-lang/actions/setupand a smoke check of the generated surface (step 4). tx3c 0.25.0 shipsjava-clientand is on the stable channel.Change
tx3-lang/actions/setup@v1..github/scripts/codegen-check.sh(mirrors rust-sdk's): installs this checkout as0.15.0-SNAPSHOT, renderstransferandcomplex, asserts identity constants,Profile,*_TIRconstants,*Paramsrecords,fromPartsseeding, the transfer fixture's typed setters and method, and the absence of generic/builder-only setters, thenmvn verifys each against the snapshot.Verification
bash -n, YAML parse. Compilation relies on this PR'sgenerated Java clientjob.🤖 Generated with Claude Code