Unify transition construction, guards, and reentry - #207
Merged
Conversation
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make construction consistent across ordinary transitions, retained-owner updates, and atomic destination-plus-owner updates:
.fromconstructs both values from schema inputs;.decodedaccepts decoded values..resolveremains available for explicit child configurations, mixed construction methods, and commands. Guards decline before construction or commands and preserve ancestor fallback.Reentry becomes one chainable modifier:
It also composes with
.from,.decoded, guards, and.updating. Named branches use.branches(...).reenter().resolve(...);to.none.reenter()remains complete without a resolver. The lint autofix preserves modifiers. Reentry still applies to the handler source, and owner updates still require complete values.Public runtime and type tests cover atomic validation, lifecycle behavior, guard fallback, explicit construction requirements, and removed options. Differential tests compare both indexed planners with the generic planner and verify that guarded transitions retain the generic path. A dedicated type-performance fixture measures the new chains; the runtime benchmark adapter supports both base and head APIs.
Changeset
Minor core changeset for public additions and the breaking reentry migration; lint fix included in the synchronized release group.
Validation
pnpm checkLocal
pnpm perf:typesandpnpm perf:runtimepassed. Reviewed the CI base-versus-PR reports: existing type scenarios are effectively unchanged, and the new construction fixture passes its budget. The five-run runtime comparison passes the noise-adjusted regression guard; throughput differences range from -1.0% to -4.5%, and retained heap is essentially unchanged.