Skip to content

Refactor Knob component styles for performance #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaddipatlaChetan24 wants to merge 1 commit into from
Closed

Refactor Knob component styles for performance #5416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions documentation-site/components/yard/knob.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,24 @@ const getTooltip = (description: string, type: string, name: string) => (
</span>
);

// Hoisted to module scope: this override never referenced its `$theme`
// argument, so it's a plain static style object rather than a function of
// $theme. Previously a brand-new function + object literal was allocated on
// every render of Knob just to return the same constant shape each time.
const RADIO_GROUP_ROOT_OVERRIDE_STYLE = {
flexWrap: "wrap",
marginTop: 0,
marginBottom: 0,
rowGap: 0,
columnGap: 0,
} as const;

// Hoisted to module scope for the same reason: a static object with no
// dependency on props/state, previously recreated on every render.
const CHECKBOX_LABEL_OVERRIDE_STYLE = {
fontWeight: 500,
} as const;

const Spacing: React.FC<{ children: React.ReactNode }> = ({ children }) => {
const [css, theme] = useStyletron();
return (
Expand Down Expand Up @@ -137,9 +155,7 @@ const Knob: React.SFC<{
}}
overrides={{
Label: {
style: {
fontWeight: 500,
},
style: CHECKBOX_LABEL_OVERRIDE_STYLE,
},
}}
>
Expand Down Expand Up @@ -184,13 +200,7 @@ const Knob: React.SFC<{
align="horizontal"
overrides={{
RadioGroupRoot: {
style: ({ $theme }) => ({
flexWrap: "wrap",
marginTop: 0,
marginBottom: 0,
rowGap: 0,
columnGap: 0,
}),
style: RADIO_GROUP_ROOT_OVERRIDE_STYLE,
},
}}
onChange={(e) => {
Expand Down