Skip to content

Prevent mutation of whitelisted array during sorting #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaddipatlaChetan24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent mutation of whitelisted array during sorting #5420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion documentation-site/components/overrides.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ import { trackEvent } from "../helpers/ga";
const isStyledExport = (exportName) => exportName.startsWith("Styled");
const getOverrideName = (exportName) => exportName.replace("Styled", "");
const getOverrides = (component, blacklisted, whitelisted) => {
if (whitelisted) return whitelisted.sort();
// Copy before sorting: Array.prototype.sort() mutates in place, and
// `whitelisted` is a prop passed in by the caller (which may be a
// shared/reused array reference, e.g. a module-level constant). Sorting
// it directly would silently reorder the caller's own array as a side
// effect.
if (whitelisted) return [...whitelisted].sort();
return component
? Object.keys(component)
.filter(isStyledExport)
Expand Down