Update theme object to include direction property - #5427
Closed
MaddipatlaChetan24 wants to merge 1 commit into
Closed
MaddipatlaChetan24 wants to merge 1 commit into
MaddipatlaChetan24 wants to merge 1 commit into
Conversation
MaddipatlaChetan24
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 23, 2026 14:10
Contributor
Author
|
please check this !! |
Collaborator
|
Not really needed. No tests provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
Description
setTheme() replaces this.state.theme entirely with a fresh object from themes[themeName] on every call, without preserving any direction override that toggleDirection() had previously merged in. Since toggleTheme() calls setTheme(), the sequence "toggle direction to RTL, then toggle the color theme" silently reverts theme.direction back to "ltr", while the separate this.state.direction field (used by DirectionContext.Provider) still correctly reports "rtl". Result: BaseProvider (which baseui components read theme.direction from) renders LTR while the rest of the app, via DirectionContext, still behaves as RTL.
Fix: setTheme() now merges the currently-active this.state.direction into the theme object it constructs, instead of dropping it.
Confirmed the desync and the fix with a standalone state-transition simulation (not run against the actual React app — no build environment available here).
Scope
Patch: Bug Fix