docs(rfc): add speculation design#230
Merged
Merged
Conversation
This was referenced Jun 9, 2026
380f0b1 to
3eddc3d
Compare
sbalabanov
reviewed
Jun 11, 2026
67da1e9 to
0ee54c9
Compare
sbalabanov
requested changes
Jul 7, 2026
sbalabanov
left a comment
Contributor
There was a problem hiding this comment.
sending it back as it is quite old, resubmit if needed
0ee54c9 to
eb56b8f
Compare
Collaborator
Author
|
Reworked and resubmitting. Reframed the design around three decisions (enumeration, selection, prioritization) + three signal-driven limit policies (dependency / selection / prioritization limit) that scale with build resources. Addresses all review comments:
PTAL @sbalabanov |
c6eceaa to
3053dd4
Compare
sbalabanov
approved these changes
Jul 7, 2026
Capture how SubmitQueue speculates before the interfaces land: the problem (dependent batches serialize behind multi-minute builds), the Base/Head path-and-tree model, where speculation sits in the orchestrator pipeline, and the two pluggable seams it splits into — tree enumeration and path selection. Also records the status-vs-action ownership split and speculation depth. Design only; the entities, store, and extension interfaces follow in later PRs in this stack. Adds doc/rfc/submitqueue/speculation.md and links it from the RFC index.
3053dd4 to
58cabeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture how SubmitQueue speculates before the interfaces land. Speculation is modeled as two layers: decision seams — enumeration and scoring describe the tree of possible bets, selection and prioritization act on it — and signal-driven limit policies that decide how much to allow at each step (dependency limit, selection limit, prioritization limit), scaling with the build system's resources. A path's score is dynamic — recomputed as dependencies land, fail, or have their builds pass — not frozen at enumeration.
Covers: the problem (dependent batches serialize behind multi-minute builds), the Base/Head path-and-tree model, where speculation sits in the orchestrator pipeline, the status-vs-action ownership split, the dependency limit as an eligibility gate (batches wait for predecessors to land rather than trimming their base), dynamic rescoring, and how prioritization rations the queue's builds against its budget.
Design only; entities, store, and extension interfaces follow in later PRs in this stack. Adds doc/rfc/submitqueue/speculation.md and links it from the RFC index.
Changes since review
Reframed from two seams (enumeration + selection) to describe/act decisions + limits, addressing @sbalabanov's review:
Test Plan
Doc-only. Rendered locally; ASCII diagrams and tables verified; no hard-wrapped prose.
Issues
Stack