Repository navigation
feat(conflict): Add a Tango client adapter for changed targets - #911
Merged
Merged
Conversation
manjari25
marked this pull request as ready for review
October 22, 2026 01:06
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 22, 2026 01:06
behinddwalls
approved these changes
Oct 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 27, 2026
manjari25
force-pushed
the
manjari/tango-client
branch
from
October 27, 2026 19:46
a9378db to
fedfd82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The tango analyzer asks a
ChangedTargetsClientwhich targets a batch affects, but nothing implements it against the Tango service. This adds the OSS adapter.What?
tangoclient.New(client, Config{Remote, Strategy})implementsChangedTargetsClientover Tango's YARPC client.max_distance: -1so Tango doesn't keep only the seed targets.github.com/uber/tangoatv0.0.46, which raisesfxto 1.24 anddigto 1.19.MODULE.bazelgets agazelle_overridebecause Tango's Bazel files target its own workspace.Test Plan
Issue