Repository navigation
fix(stovepipe): record broken facts from record DLQ - #946
Merged
Merged
Conversation
mnoah1
marked this pull request as ready for review
October 27, 2026 14:47
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 27, 2026 14:47
prathshenoy
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Record-stage errors can leave an already failed request without a repository validation fact: project resolution fails before the fact write, and the DLQ previously retained only
record_abandoned.What?
Recover a missing broken repository fact from the record DLQ for requests already in
failed, regardless of the original record error. Preserve existing immutable facts, retain fact history, and publishvalidation.repository.recordedafter persistence. Leave project verdicts and project completion unresolved. Share the existing fact-recording helpers and wire the hook registry into the DLQ controller.Test Plan
./tool/bazel test //stovepipe/controller/record:go_default_test //service/stovepipe/server:go_default_test --test_output=errorsmake fmt lint check-tidy check-gazelle