Skip to content

Update Rosetta API spec to v1.0.34 - #13

Merged
jSylvestre merged 1 commit into
mainfrom
JCS/Schema20280820
Aug 21, 2026
Merged

Update Rosetta API spec to v1.0.34#13
jSylvestre merged 1 commit into
mainfrom
JCS/Schema20280820

Conversation

@jSylvestre

@jSylvestre jSylvestre commented Aug 20, 2026

Copy link
Copy Markdown
Member

Regenerate client to reflect Rosetta API specification v1.0.34.

This update introduces:

  • The job_indicator property for EmployeeAssociation and PpsAssociationRecord types.
  • firstnamelike and lastnamelike filters for PeopleFilterInput.

Summary by CodeRabbit

  • New Features
    • Added firstnamelike and lastnamelike filters for people searches.
    • Added job indicator information to employee association records, with documented values: N, S, and P.
  • Documentation
    • Updated API specifications and examples to reflect the new filters and job indicator fields.
    • Updated the Rosetta API specification badge to version v1.0.34.

Regenerate client to reflect Rosetta API specification v1.0.34.

This update introduces:
- The `job_indicator` property for `EmployeeAssociation` and `PpsAssociationRecord` types.
- `firstnamelike` and `lastnamelike` filters for `PeopleFilterInput`.
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02556f48-0228-408c-8a10-70d9cfde707d

📥 Commits

Reviewing files that changed from the base of the PR and between e0857dd and 5cb1088.

⛔ Files ignored due to path filters (1)
  • UCD.Rosetta.Client/Generated/RosettaApiClient.g.cs is excluded by !**/generated/**
📒 Files selected for processing (4)
  • README.md
  • specs/rosetta-api.graphql
  • specs/rosetta-api.json
  • update-spec.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Rosetta API specification adds employee-association indicators and name-like people filters. JSON schemas and examples reflect the new fields. The update script and README now use version 1.0.34.

Changes

API specification updates

Layer / File(s) Summary
API contract fields and schemas
specs/rosetta-api.graphql, specs/rosetta-api.json
The specification adds firstnamelike and lastnamelike filters. Employee-association records expose documented job_indicator values N, S, and P.
Association response examples
specs/rosetta-api.json
Employee-association response examples include primary and secondary job_indicator values.
Specification version synchronization
update-spec.sh, README.md
The update script defaults to version 1.0.34. The README badge references v1.0.34.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5cb10

This PR updates the generated client and API specifications for the documented v1.0.34 fields and filters. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: sprucely

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating the Rosetta API specification to version 1.0.34.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch JCS/Schema20280820

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jSylvestre
jSylvestre merged commit bb38304 into main Aug 21, 2026
3 checks passed
@jSylvestre
jSylvestre deleted the JCS/Schema20280820 branch August 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant