Skip to content

Merge remote-tracking branch 'origin/main' into v2#4

Open
zbeyens wants to merge 12 commits intomainfrom
v2
Open

Merge remote-tracking branch 'origin/main' into v2#4
zbeyens wants to merge 12 commits intomainfrom
v2

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented May 4, 2026

Description
A clear and concise description of what this pull request solves. (Please do not just link to a long issue thread. Instead include a clear description here or your pull request will likely not be reviewed as quickly.)

Issue
Fixes: (link to issue)

Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)

Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: 4764d33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
slate-dom Major
slate-react Major
slate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce2bd6c68c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +143 to +144
if (op.type === 'set_selection' && !isInTransaction(editor)) {
setCurrentMarks(editor, null)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Clear cursor marks when applying set_selection

The set_selection mark reset is now guarded by !isInTransaction(editor), but this code path executes only after apply has entered a transaction (either directly or via the runEditorTransaction wrapper), so the condition is never true. In editors with listeners (the common slate-react path), selection changes no longer clear pending marks, so subsequent typing can incorrectly inherit stale formatting after cursor moves. This regresses the prior behavior noted by the inline comment and can surface as unexpected bold/italic carryover.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant