169 author name firstname lastname spacing on details page

src/app/item-page/full/full-item-page.component.html

@@ -47,7 +47,12 @@
               <td>{{mdEntry.key}}</td>
               <td>
                 <span *ngFor="let value of mdValue.value.split(SEPARATOR); let last=last;">
-                  <span [innerHTML]="makeLinks(value) | dsReplace: [';', ' ']" ></span>
+                  <span *ngIf="mdEntry.key === 'dc.contributor.author'; else otherField">
+                    <span [innerHTML]="makeLinks(value | dsFormatAuthor) | dsReplace: [';', ' ']"></span>
+                  </span>
+                  <ng-template #otherField>
+                    <span [innerHTML]="makeLinks(value) | dsReplace: [';', ' ']"></span>
+                  </ng-template>
                   <span *ngIf="!last" [innerHTML]="' '"></span>
                 </span>
               </td>

src/app/shared/form/builder/ds-dynamic-form-ui/models/clarin-name.model.ts

@@ -38,7 +38,7 @@ export class DynamicClarinNameModel extends DynamicConcatModel {
   constructor(config: DynamicConcatModelConfig, layout?: DynamicFormControlLayout) {
 
     super(config, layout);
-    this.separator = ',';
+    this.separator = ', ';
     this.relationship = config.relationship;
     this.repeatable = config.repeatable;
     this.required = config.required;

src/app/shared/form/builder/parsers/clarin-name-field-parser.spec.ts

@@ -94,7 +94,7 @@ describe('ClarinNameFieldParser test suite', () => {
 
     const fieldModel = parser.parse();
 
-    expect((fieldModel as DynamicConcatModel).separator).toBe(',');
+    expect((fieldModel as DynamicConcatModel).separator).toBe(', ');
   });
 
   it('should set init value properly', () => {

src/app/shared/shared.module.ts

@@ -301,6 +301,7 @@ import { ClarinDateService } from './clarin-date.service';
 import { ItemIdentifierService } from './item-identifier.service';
 import { ClarinLicenseRequiredInfoCheckedPipe } from './utils/clarin-license-required-info-checked.pipe';
 import { DsLangPipe } from './utils/ds-lang.pipe';
+import { FormatAuthorPipe } from './utils/format-author.pipe';
 
 const MODULES = [
   CommonModule,
@@ -349,7 +350,8 @@ const PIPES = [
   CharToEndPipe,
   ClarinSafeHtmlPipe,
   ReplacePipe,
-  DsLangPipe
+  DsLangPipe,
+  FormatAuthorPipe
 ];
 
 const COMPONENTS = [

src/app/shared/utils/format-author.pipe.spec.ts

@@ -0,0 +1,28 @@
+import { FormatAuthorPipe } from './format-author.pipe';
+
+describe('FormatAuthorPipe', () => {
+  let pipe: FormatAuthorPipe;
+
+  beforeEach(() => {
+    pipe = new FormatAuthorPipe();
+  });
+
+  it('should create', () => {
+    expect(pipe).toBeTruthy();
+  });
+
+  it('should add single space after comma when missing', () => {
+    expect(pipe.transform('Doe,John')).toEqual('Doe, John');
+  });
+
+  it('should keep single space after comma unchanged', () => {
+    expect(pipe.transform('Doe, John')).toEqual('Doe, John');
+  });
+
+  it('should return value as-is when there is no comma', () => {
+    expect(pipe.transform('')).toEqual('');
+    expect(pipe.transform(null as any)).toBeNull();
+    expect(pipe.transform('John Doe')).toEqual('John Doe');
+    expect(pipe.transform(undefined as any)).toBeUndefined();
+  });
+});

src/app/shared/utils/format-author.pipe.ts

@@ -0,0 +1,9 @@
+import { Pipe, PipeTransform } from '@angular/core';
+
+@Pipe({ name: 'dsFormatAuthor' })
+export class FormatAuthorPipe implements PipeTransform {
+  transform(value: string): string {
+    // Normalise comma followed by zero or more whitespace to a single comma + space
+    return value?.replace(/,\s*(?=\S)/g, ', ') || value;
+  }
+}