Correct the equation of time#253
Merged
Merged
Conversation
dustinswales
approved these changes
Jun 1, 2026
dustinswales
left a comment
dustinswales
left a comment
Collaborator
There was a problem hiding this comment.
@clark-evans Looks good to me. Thank you for making these changes.
AndersJensen-NOAA
approved these changes
Jun 3, 2026
clark-evans
moved this from Needs review
to Needs final review
in MPAS-A PRs to process
dustinswales
moved this from Needs final review
to Ready to merge
in MPAS-A PRs to process
github-project-automation
Bot
moved this from Ready to merge
to Done
in MPAS-A PRs to process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements wrf-model/WRF#2334 for RRTMG shortwave, correcting two parameters in the equation of time that we implemented with #201.
Mandatory Questions
Reviews