Skip to content

4198 raise exceptions on negative fuel ion charge density and temperature profile elements#4217

Open
jonmaddock wants to merge 2 commits intomainfrom
4198-raise-exceptions-on-negative-fuel-ion-charge-density-and-temperature-profile-elements
Open

4198 raise exceptions on negative fuel ion charge density and temperature profile elements#4217
jonmaddock wants to merge 2 commits intomainfrom
4198-raise-exceptions-on-negative-fuel-ion-charge-density-and-temperature-profile-elements

Conversation

@jonmaddock
Copy link
Copy Markdown
Contributor

Both of these unphysical possibilities are always eventually fatal during model evaluation, but were previously confusing due to only causing indirect downstream errors (e.g. in bootstrap current calculation). Now they raise exceptions at source.

@jonmaddock jonmaddock requested a review from a team as a code owner May 1, 2026 14:27
@jonmaddock jonmaddock requested a review from chris-ashe May 1, 2026 14:28
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.15%. Comparing base (9af55b4) to head (83985ef).

Files with missing lines Patch % Lines
process/models/physics/bootstrap_current.py 50.00% 1 Missing ⚠️
process/models/physics/physics.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
- Coverage   52.15%   52.15%   -0.01%     
==========================================
  Files         148      148              
  Lines       30431    30435       +4     
==========================================
+ Hits        15870    15872       +2     
- Misses      14561    14563       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise exceptions on negative fuel ion charge density and temperature profile elements

2 participants