Updated PF numbering in outputs

[kj5248]

Description

closes #4502

In MFILE.DAT and OUT.DAT there were many places where PF coils were numbered from 0. This has been updated to start from 1.

Also in places such as Volt Second Consumption and Waveforms all the circuits were numbers, the final number has now shows CS as that's what it is. However in the PF Circuit Waveform Data section I left the circuit_var_name as the original as it is a var not an output name.

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (8fe9306) to head (534fe42).
⚠️ Report is 28 commits behind head on main.

Files with missing lines	Patch %	Lines
process/models/pfcoil.py	0.00%	53 Missing ⚠️
process/core/io/plot/summary.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4519      +/-   ##
==========================================
+ Coverage   49.30%   49.83%   +0.52%     
==========================================
  Files         150      151       +1     
  Lines       29769    29889     +120     
==========================================
+ Hits        14679    14894     +215     
+ Misses      15090    14995      -95     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chris-ashe]

@kj5248 Have noticed that the coil numbering in the plots now starts from 2. Can you quickly update that to and I will take a full look after

[chris-ashe]

All OUT.DAT looks ok, though I am getting a bug for plot_pf_dimensions() when running the ST regression were it does not do the final coil, Coil 8 in this case

[kj5248]

@chris-ashe > All OUT.DAT looks ok, though I am getting a bug for plot_pf_dimensions() when running the ST regression were it does not do the final coil, Coil 8 in this case

When I run the ST regression and use plot summary on it i get this which has 8 PF coils?

Although I did notice somewhere in the OUT.dat for ST which seems wrong but wanted to double check. Under waveforms it drops to 7 coils and a CS, feels like this is wrong?

[chris-ashe]

@chris-ashe > All OUT.DAT looks ok, though I am getting a bug for plot_pf_dimensions() when running the ST regression were it does not do the final coil, Coil 8 in this case

When I run the ST regression and use plot summary on it i get this which has 8 PF coils?

Although I did notice somewhere in the OUT.dat for ST which seems wrong but wanted to double check. Under waveforms it drops to 7 coils and a CS, feels like this is wrong?

Yeah, there must be a dodgy difference of 1 somewhere, the coil number should always be even. Also, if possible can you apply tabulate to the output to make everything line up properly, 2 birds with one stone

[kj5248]

Tabulated the outputs. I also noticed what I am pretty sure is a duplicated output (it is in table form in the waveforms section) so I removed it @chris-ashe:

[je-cook]

I dont think you need to loop over the lines I think you can write it directly as @timothy-nunn has done here https://github.com/ukaea/PROCESS/pull/4565/changes

Suggested change

	for line in tabulate(
	rows,
	headers=headers[1:],
	tablefmt="plain",
	disable_numparse=True,
	).splitlines():
	op.write(self.outfile, line)
	op.write(self.outfile, tabulate(
	rows,
	headers=headers[1:],
	tablefmt="plain",
	disable_numparse=True,
	))